Skip to content

e2e: use ConformanceOptions.Hook#6215

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:adopt-hook
Jun 3, 2025
Merged

e2e: use ConformanceOptions.Hook#6215
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:adopt-hook

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 28, 2025

fixes: #3415

@zirain zirain requested a review from a team as a code owner May 28, 2025 23:33
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (2e168a8) to head (9bade48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6215      +/-   ##
==========================================
+ Coverage   70.48%   70.51%   +0.03%     
==========================================
  Files         220      220              
  Lines       36611    36611              
==========================================
+ Hits        25805    25817      +12     
+ Misses       9280     9270      -10     
+ Partials     1526     1524       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for driving this all the way from upstream till here !

@arkodg arkodg requested review from a team May 30, 2025 20:39
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit fb5a98f into envoyproxy:main Jun 3, 2025
29 of 31 checks passed
@zirain zirain deleted the adopt-hook branch June 3, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a hook for failed test suite

3 participants